From 85ce6512f0466a67be054c4a23fc066136fd3d8a Mon Sep 17 00:00:00 2001 From: Nick Floyd <139819+nickfloyd@users.noreply.github.com> Date: Thu, 6 Apr 2023 19:18:57 +0000 Subject: [PATCH] updated notes to be more accurate as to what was being tested --- spec/octokit/error_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/octokit/error_spec.rb b/spec/octokit/error_spec.rb index c29c11827..e3856465e 100644 --- a/spec/octokit/error_spec.rb +++ b/spec/octokit/error_spec.rb @@ -2,9 +2,9 @@ require 'octokit/error' -# I have mixed feelings about testing private methods due to potentially breaking encapsulation but -# given the nature of this method and the fact that it is meant to keep secrets out of logs -# I think it is worth it and will help us know if something changes in this area. +# I have mixed feelings about testing this method due to potentially breaking encapsulation but +# given the nature of this method and the fact that it is meant to keep secrets out of logs. +# In this case, it is worth it and will help us know if something changes in this area. describe Octokit::Error do describe '.build_error_message' do it 'redacts api_key' do