Skip to content

Commit

Permalink
updated notes to be more accurate as to what was being tested
Browse files Browse the repository at this point in the history
  • Loading branch information
nickfloyd committed Apr 6, 2023
1 parent 8fe063f commit 85ce651
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions spec/octokit/error_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

require 'octokit/error'

# I have mixed feelings about testing private methods due to potentially breaking encapsulation but
# given the nature of this method and the fact that it is meant to keep secrets out of logs
# I think it is worth it and will help us know if something changes in this area.
# I have mixed feelings about testing this method due to potentially breaking encapsulation but
# given the nature of this method and the fact that it is meant to keep secrets out of logs.
# In this case, it is worth it and will help us know if something changes in this area.
describe Octokit::Error do
describe '.build_error_message' do
it 'redacts api_key' do
Expand Down

0 comments on commit 85ce651

Please sign in to comment.