Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pagination support to Reactions Clients #1661

Closed
4 tasks
ryangribble opened this issue Sep 3, 2017 · 1 comment
Closed
4 tasks

Add missing pagination support to Reactions Clients #1661

ryangribble opened this issue Sep 3, 2017 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@ryangribble
Copy link
Contributor

Refer #1659

Implement Pagination on the following clients

ICommitCommentReactionsClient and IObservableCommitCommentReactionsClient

  • GetAll(string owner, string name, int number)
  • GetAll(long repositoryId, int number)

IIssueCommentReactionsClient and IObservableIssueCommentReactionsClient

  • GetAll(string owner, string name, int number)
  • GetAll(long repositoryId, int number)

IIssueReactionsClient and IObservableIssueReactionsClient

  • GetAll(string owner, string name, int number)
  • GetAll(long repositoryId, int number)

IPullRequestReviewCommentReactionsClient and IObservablePullRequestReviewCommentReactionsClient

  • GetAll(string owner, string name, int number)
  • GetAll(long repositoryId, int number)

Checklist

  • Remove convention test exclusion [ExcludeFromPaginationApiOptionsConventionTest]

  • Add ApiOptions overload

    • make existing methods call new overload with ApiOptions.None
  • Update unit tests

    • Adjust for ApiOptions parameter
    • Add null check for ApiOptions
  • Add pagination Integration tests

    • ReturnsCorrectCountOfXWithoutStart
    • ReturnsCorrectCountOfXWithStart
    • ReturnsDistinctXBasedOnStartPage
@ryangribble ryangribble changed the title Add missing Pagination support to Reactions clients Add missing Pagination support to Reactions Clients Sep 3, 2017
@ryangribble ryangribble changed the title Add missing Pagination support to Reactions Clients Add missing pagination support to Reactions Clients Sep 3, 2017
@ryangribble ryangribble added this to the Missing Pagination Support milestone Dec 1, 2017
@hnrkndrssn
Copy link
Contributor

I'll 🙌 for this one.

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants