diff --git a/Octokit.Reactive/Clients/IObservableEventsClient.cs b/Octokit.Reactive/Clients/IObservableEventsClient.cs index 558b7f7055..7bf37345a7 100644 --- a/Octokit.Reactive/Clients/IObservableEventsClient.cs +++ b/Octokit.Reactive/Clients/IObservableEventsClient.cs @@ -76,7 +76,7 @@ public interface IObservableEventsClient /// /// The owner of the repository /// The name of the repository - IObservable GetAllIssuesForRepository(string owner, string name); + IObservable GetAllIssuesForRepository(string owner, string name); /// /// Gets all the issue events for a given repository @@ -85,7 +85,7 @@ public interface IObservableEventsClient /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository /// /// The Id of the repository - IObservable GetAllIssuesForRepository(long repositoryId); + IObservable GetAllIssuesForRepository(long repositoryId); /// /// Gets all the issue events for a given repository @@ -96,7 +96,7 @@ public interface IObservableEventsClient /// The owner of the repository /// The name of the repository /// Options for changing the API response - IObservable GetAllIssuesForRepository(string owner, string name, ApiOptions options); + IObservable GetAllIssuesForRepository(string owner, string name, ApiOptions options); /// /// Gets all the issue events for a given repository @@ -106,7 +106,7 @@ public interface IObservableEventsClient /// /// The Id of the repository /// Options for changing the API response - IObservable GetAllIssuesForRepository(long repositoryId, ApiOptions options); + IObservable GetAllIssuesForRepository(long repositoryId, ApiOptions options); /// /// Gets all the events for a given repository network diff --git a/Octokit.Reactive/Clients/ObservableEventsClient.cs b/Octokit.Reactive/Clients/ObservableEventsClient.cs index b365ea0ac6..ea3a09bc7d 100644 --- a/Octokit.Reactive/Clients/ObservableEventsClient.cs +++ b/Octokit.Reactive/Clients/ObservableEventsClient.cs @@ -107,14 +107,14 @@ public IObservable GetAllForRepository(long repositoryId, ApiOptions o } /// - /// Gets all the events for a given repository + /// Gets all the issue events for a given repository /// /// /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository /// /// The owner of the repository /// The name of the repository - public IObservable GetAllIssuesForRepository(string owner, string name) + public IObservable GetAllIssuesForRepository(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); @@ -129,13 +129,13 @@ public IObservable GetAllIssuesForRepository(string owner, string name /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository /// /// The Id of the repository - public IObservable GetAllIssuesForRepository(long repositoryId) + public IObservable GetAllIssuesForRepository(long repositoryId) { return GetAllIssuesForRepository(repositoryId, ApiOptions.None); } /// - /// Gets all the events for a given repository + /// Gets all the issue events for a given repository /// /// /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository @@ -143,13 +143,13 @@ public IObservable GetAllIssuesForRepository(long repositoryId) /// The owner of the repository /// The name of the repository /// Options for changing the API response - public IObservable GetAllIssuesForRepository(string owner, string name, ApiOptions options) + public IObservable GetAllIssuesForRepository(string owner, string name, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNull(options, "options"); - return _connection.GetAndFlattenAllPages(ApiUrls.IssuesEvents(owner, name), options); + return _connection.GetAndFlattenAllPages(ApiUrls.IssuesEvents(owner, name), options); } /// @@ -160,11 +160,11 @@ public IObservable GetAllIssuesForRepository(string owner, string name /// /// The Id of the repository /// Options for changing the API response - public IObservable GetAllIssuesForRepository(long repositoryId, ApiOptions options) + public IObservable GetAllIssuesForRepository(long repositoryId, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); - return _connection.GetAndFlattenAllPages(ApiUrls.IssuesEvents(repositoryId), options); + return _connection.GetAndFlattenAllPages(ApiUrls.IssuesEvents(repositoryId), options); } /// diff --git a/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs index 60ae9041b0..3cef1ffd54 100644 --- a/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs +++ b/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs @@ -170,7 +170,7 @@ public TheGetAllIssuesForRepositoryMethod() _eventsClient = new ObservableEventsClient(Helper.GetAuthenticatedClient()); } - [IntegrationTest(Skip = "These tests just don't work any more")] + [IntegrationTest] public async Task ReturnsRepositoryEvents() { var options = new ApiOptions @@ -185,7 +185,7 @@ public async Task ReturnsRepositoryEvents() Assert.NotEmpty(repositoryEvents); } - [IntegrationTest(Skip = "These tests just don't work any more")] + [IntegrationTest] public async Task ReturnsCorrectCountOfRepositoryEventsWithoutStart() { var options = new ApiOptions @@ -199,7 +199,7 @@ public async Task ReturnsCorrectCountOfRepositoryEventsWithoutStart() Assert.Equal(5, repositoryEvents.Count); } - [IntegrationTest(Skip = "These tests just don't work any more")] + [IntegrationTest] public async Task ReturnsCorrectCountOfRepositoryEventsWithStart() { var options = new ApiOptions @@ -214,7 +214,7 @@ public async Task ReturnsCorrectCountOfRepositoryEventsWithStart() Assert.Equal(5, repositoryEvents.Count); } - [IntegrationTest(Skip = "These tests just don't work any more")] + [IntegrationTest] public async Task ReturnsDistinctRepositoryEventsBasedOnStartPage() { var startOptions = new ApiOptions diff --git a/Octokit.Tests/Clients/EventsClientTests.cs b/Octokit.Tests/Clients/EventsClientTests.cs index 6f543f7dc1..82c1084d0f 100644 --- a/Octokit.Tests/Clients/EventsClientTests.cs +++ b/Octokit.Tests/Clients/EventsClientTests.cs @@ -154,7 +154,7 @@ public async Task RequestsCorrectUrl() await client.GetAllIssuesForRepository("fake", "repo"); - connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/issues/events"), Args.ApiOptions); + connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/issues/events"), Args.ApiOptions); } [Fact] @@ -165,7 +165,7 @@ public async Task RequestsCorrectUrlWithRepositoryId() await client.GetAllIssuesForRepository(1); - connection.Received().GetAll(Arg.Is(u => u.ToString() == "repositories/1/issues/events"), Args.ApiOptions); + connection.Received().GetAll(Arg.Is(u => u.ToString() == "repositories/1/issues/events"), Args.ApiOptions); } [Fact] @@ -183,7 +183,7 @@ public async Task RequestsCorrectUrlWithApiOptions() await client.GetAllIssuesForRepository("fake", "repo", options); - connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/issues/events"), options); + connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/issues/events"), options); } [Fact] @@ -201,7 +201,7 @@ public async Task RequestsCorrectUrlWithRepositoryIdWithApiOptions() await client.GetAllIssuesForRepository(1, options); - connection.Received().GetAll(Arg.Is(u => u.ToString() == "repositories/1/issues/events"), options); + connection.Received().GetAll(Arg.Is(u => u.ToString() == "repositories/1/issues/events"), options); } [Fact] diff --git a/Octokit.Tests/Reactive/ObservableEventsClientTests.cs b/Octokit.Tests/Reactive/ObservableEventsClientTests.cs index 8d06a257d6..9e01765e2a 100644 --- a/Octokit.Tests/Reactive/ObservableEventsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableEventsClientTests.cs @@ -156,7 +156,7 @@ public void RequestsCorrectUrl() client.GetAllIssuesForRepository("fake", "repo"); - gitHubClient.Connection.Received(1).Get>(new Uri("repos/fake/repo/issues/events", UriKind.Relative), + gitHubClient.Connection.Received(1).Get>(new Uri("repos/fake/repo/issues/events", UriKind.Relative), Args.EmptyDictionary, null); } @@ -168,7 +168,7 @@ public void RequestsCorrectUrlWithRepositoryId() client.GetAllIssuesForRepository(1); - gitHubClient.Connection.Received(1).Get>(new Uri("repositories/1/issues/events", UriKind.Relative), + gitHubClient.Connection.Received(1).Get>(new Uri("repositories/1/issues/events", UriKind.Relative), Args.EmptyDictionary, null); } @@ -187,7 +187,7 @@ public void RequestsCorrectUrlWithApiOptions() client.GetAllIssuesForRepository("fake", "repo", options); - gitHubClient.Connection.Received(1).Get>(new Uri("repos/fake/repo/issues/events", UriKind.Relative), + gitHubClient.Connection.Received(1).Get>(new Uri("repos/fake/repo/issues/events", UriKind.Relative), Arg.Is>(d => d.Count == 2), null); } @@ -206,7 +206,7 @@ public void RequestsCorrectUrlWithRepositoryIdWithApiOptions() client.GetAllIssuesForRepository(1, options); - gitHubClient.Connection.Received(1).Get>(new Uri("repositories/1/issues/events", UriKind.Relative), + gitHubClient.Connection.Received(1).Get>(new Uri("repositories/1/issues/events", UriKind.Relative), Arg.Is>(d => d.Count == 2), null); } diff --git a/Octokit/Clients/EventsClient.cs b/Octokit/Clients/EventsClient.cs index 9016ae865a..431dc34c7c 100644 --- a/Octokit/Clients/EventsClient.cs +++ b/Octokit/Clients/EventsClient.cs @@ -115,7 +115,7 @@ public Task> GetAllForRepository(long repositoryId, ApiO /// /// The owner of the repository /// The name of the repository - public Task> GetAllIssuesForRepository(string owner, string name) + public Task> GetAllIssuesForRepository(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); @@ -130,7 +130,7 @@ public Task> GetAllIssuesForRepository(string owner, str /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository /// /// The Id of the repository - public Task> GetAllIssuesForRepository(long repositoryId) + public Task> GetAllIssuesForRepository(long repositoryId) { return GetAllIssuesForRepository(repositoryId, ApiOptions.None); } @@ -144,13 +144,13 @@ public Task> GetAllIssuesForRepository(long repositoryId /// The owner of the repository /// The name of the repository /// Options for changing the API response - public Task> GetAllIssuesForRepository(string owner, string name, ApiOptions options) + public Task> GetAllIssuesForRepository(string owner, string name, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNull(options, "options"); - return ApiConnection.GetAll(ApiUrls.IssuesEvents(owner, name), options); + return ApiConnection.GetAll(ApiUrls.IssuesEvents(owner, name), options); } /// @@ -161,11 +161,11 @@ public Task> GetAllIssuesForRepository(string owner, str /// /// The Id of the repository /// Options for changing the API response - public Task> GetAllIssuesForRepository(long repositoryId, ApiOptions options) + public Task> GetAllIssuesForRepository(long repositoryId, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); - return ApiConnection.GetAll(ApiUrls.IssuesEvents(repositoryId), options); + return ApiConnection.GetAll(ApiUrls.IssuesEvents(repositoryId), options); } /// diff --git a/Octokit/Clients/IEventsClient.cs b/Octokit/Clients/IEventsClient.cs index a1a7ed521e..2ed95b37c8 100644 --- a/Octokit/Clients/IEventsClient.cs +++ b/Octokit/Clients/IEventsClient.cs @@ -78,7 +78,7 @@ public interface IEventsClient /// /// The owner of the repository /// The name of the repository - Task> GetAllIssuesForRepository(string owner, string name); + Task> GetAllIssuesForRepository(string owner, string name); /// /// Gets all the issue events for a given repository @@ -87,7 +87,7 @@ public interface IEventsClient /// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository /// /// The Id of the repository - Task> GetAllIssuesForRepository(long repositoryId); + Task> GetAllIssuesForRepository(long repositoryId); /// /// Gets all the issue events for a given repository @@ -98,7 +98,7 @@ public interface IEventsClient /// The owner of the repository /// The name of the repository /// Options for changing the API response - Task> GetAllIssuesForRepository(string owner, string name, ApiOptions options); + Task> GetAllIssuesForRepository(string owner, string name, ApiOptions options); /// /// Gets all the issue events for a given repository @@ -108,7 +108,7 @@ public interface IEventsClient /// /// The Id of the repository /// Options for changing the API response - Task> GetAllIssuesForRepository(long repositoryId, ApiOptions options); + Task> GetAllIssuesForRepository(long repositoryId, ApiOptions options); /// /// Gets all the events for a given repository network