Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v5 #343

Merged
merged 10 commits into from
Jun 20, 2023
Merged

feat: v5 #343

merged 10 commits into from
Jun 20, 2023

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Sep 10, 2022 •
edited by wolfy1339
Loading

Breaking changes

  • drop onUnhandledRequest middleware option
  • returns a 404 response for unknown routes
  • drop support for NodeJS v14, v16

@baoshan
fix: return 404 for unknown routes (#341)
4fd0a76 
BREAKING CHANGE: drop `onUnhandledRequest` middleware option
@gr2m gr2m marked this pull request as draft September 10, 2022 20:59
@gr2m
Copy link
Contributor Author

gr2m commented Sep 10, 2022

fyi @baoshan ☝🏼

@gr2m gr2m added the Type: Feature New feature or request label Sep 10, 2022
@wolfy1339 wolfy1339 added the Type: Breaking change Used to note any change that requires a major version bump label Nov 7, 2022
wolfy1339 and others added 7 commits April 28, 2023 14:00
@wolfy1339 wolfy1339 marked this pull request as ready for review June 18, 2023 18:33
kfcampbell
kfcampbell approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the merge conflict in package-lock.json by regenerating the file during the merge. I think this is good to go now!

@gr2m gr2m merged commit 7a781c5 into main Jun 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339
Copy link
Member

Fyi this depends on the beta version of @octokit/core, we should get that taken care of ASAP

@nickfloyd nickfloyd changed the title v5 feat: v5 Jun 22, 2023
@oscard0m oscard0m mentioned this pull request Jul 19, 2023
Closed
5 tasks
@wolfy1339 wolfy1339 deleted the beta branch February 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junettealice junettealice junettealice approved these changes

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gr2m @wolfy1339 @kfcampbell @junettealice @baoshan