fix(bundlesize): move 'aws-lambda' as devDependency

[oscard0m]

Description

Move aws-lambda dependency from optionalDependency to devDependency

Context

This prevents users from installing aws-lambda since this dependency is installed by default.
Fixes #330

Previous context: #283

[oscard0m]

@baoshan @wolfy1339 I would like you to take a look at this if you have time.
Thank you!

[wolfy1339]

Can we remove it altogether instead? It's not used in the code, only the types package is

[wolfy1339]

The types are a runtime dependency for typescript

[gr2m]

Ugh. @wolfy1339 is right in that it is a production dependency when using typescript. It's really annoying, I really wish we had typeDependencies for use cases like this.

The only thing that I could think of would be to remove the middleware entirely from this repository, and release it in an external package, such as @octokit/middleware-aws-lambda-oauth or similar?

I really would like to remove aws-lambda from the production dependencies, it trickles down to @octokit/app and then octokit, and we are trying to make careful about external dependencies.

What do you think?

[oscard0m]

The types are a runtime dependency for typescript

Good catch @wolfy1339. Always saving me 👼🏽

[oscard0m]

I really would like to remove aws-lambda from the production dependencies, it trickles down to @octokit/app and then octokit, and we are trying to make careful about external dependencies.

What do you think?

I completely agree. I created an issue.

In the meantime, is there an easy way to make our CI fail if we remove a required dependency for production as devDependency?

[wolfy1339]

I don't think there's an easy way to check, since we would still need dev dependencies for testing

[github-actions]

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀