Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): clarify GitObject#{since,until} #955

Merged
merged 2 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -4865,12 +4865,14 @@ type Commit implements GitObject & Node & Subscribable & UniformResourceLocatabl
path: String

"""
Allows specifying a beginning time or date for fetching commits.
Allows specifying a beginning time or date for fetching commits. Unexpected
results may be returned for dates not between 1970-01-01 and 2099-12-13 (inclusive).
"""
since: GitTimestamp

"""
Allows specifying an ending time or date for fetching commits.
Allows specifying an ending time or date for fetching commits. Unexpected
results may be returned for dates not between 1970-01-01 and 2099-12-13 (inclusive).
"""
until: GitTimestamp
): CommitHistoryConnection!
Expand Down
4 changes: 2 additions & 2 deletions schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -12549,7 +12549,7 @@
},
{
"name": "since",
"description": "Allows specifying a beginning time or date for fetching commits.",
"description": "Allows specifying a beginning time or date for fetching commits. Unexpected results may be returned for dates not between 1970-01-01 and 2099-12-13 (inclusive).",
"type": {
"kind": "SCALAR",
"name": "GitTimestamp",
Expand All @@ -12559,7 +12559,7 @@
},
{
"name": "until",
"description": "Allows specifying an ending time or date for fetching commits.",
"description": "Allows specifying an ending time or date for fetching commits. Unexpected results may be returned for dates not between 1970-01-01 and 2099-12-13 (inclusive).",
"type": {
"kind": "SCALAR",
"name": "GitTimestamp",
Expand Down
Loading