From b22b240d59f894252c93a1328e0d76d7e3af33bf Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Wed, 25 Sep 2024 00:20:08 +0200 Subject: [PATCH 1/4] test(types): add --exactOptionalPropertyTypes option --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 848d06706..17bc71ff7 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "lint:fix": "prettier --write '{src,test}/**/*.{ts,md}' README.md package.json", "pretest": "npm run -s lint", "test": "vitest --coverage", - "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions test/typescript-validate.ts" + "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions --exactOptionalPropertyTypes test/typescript-validate.ts" }, "repository": "github:octokit/core.js", "keywords": [ From d4aef7f241972d3340bbf7da5b8073beb964c9ca Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Wed, 25 Sep 2024 00:24:54 +0200 Subject: [PATCH 2/4] test(types): add --strictNullChecks option --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 17bc71ff7..05054d6b3 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "lint:fix": "prettier --write '{src,test}/**/*.{ts,md}' README.md package.json", "pretest": "npm run -s lint", "test": "vitest --coverage", - "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions --exactOptionalPropertyTypes test/typescript-validate.ts" + "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions --exactOptionalPropertyTypes --strictNullChecks test/typescript-validate.ts" }, "repository": "github:octokit/core.js", "keywords": [ From 1732825712a83b96f13d54c9581154818f853005 Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Wed, 25 Sep 2024 00:29:01 +0200 Subject: [PATCH 3/4] test(types): enable 'strict' option --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 05054d6b3..ee1e09c1d 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "lint:fix": "prettier --write '{src,test}/**/*.{ts,md}' README.md package.json", "pretest": "npm run -s lint", "test": "vitest --coverage", - "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions --exactOptionalPropertyTypes --strictNullChecks test/typescript-validate.ts" + "test:typescript": "npx tsc --noEmit --declaration --noUnusedLocals --module node16 --moduleResolution node16 --allowImportingTsExtensions --exactOptionalPropertyTypes --strict test/typescript-validate.ts" }, "repository": "github:octokit/core.js", "keywords": [ From 4cc9e99f8fd732bd97c32eebfe636218ce24c947 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 24 Sep 2024 18:33:10 -0400 Subject: [PATCH 4/4] chore(deps): update dependency @octokit/tsconfig to v4 (#703) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- package-lock.json | 11 ++++++----- package.json | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 370e9090c..dd7886c30 100644 --- a/package-lock.json +++ b/package-lock.json @@ -21,7 +21,7 @@ "@octokit/auth-action": "^5.0.0", "@octokit/auth-app": "^7.0.0", "@octokit/auth-oauth-app": "^8.0.0", - "@octokit/tsconfig": "^3.0.0", + "@octokit/tsconfig": "^4.0.0", "@sinonjs/fake-timers": "^13.0.0", "@types/jest": "^29.0.0", "@types/lolex": "^5.1.0", @@ -1146,10 +1146,11 @@ } }, "node_modules/@octokit/tsconfig": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/@octokit/tsconfig/-/tsconfig-3.0.0.tgz", - "integrity": "sha512-tQLwgXYfBq9iUbOq26kWCzsJL6DY7qjOLzqcg5tCFQ4ob48H47iX98NudHW7S5OQ/fpSKYJhb3eQehyBNzYjfA==", - "dev": true + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/@octokit/tsconfig/-/tsconfig-4.0.0.tgz", + "integrity": "sha512-hRd6UhX19m+8WhfrEpNLtm9TjuizYSG/dE0a+ivU71ylSxABVe4mEK+JMAGdjj6/gIQ+5DPegTPofi4P8VC5IA==", + "dev": true, + "license": "MIT" }, "node_modules/@octokit/types": { "version": "13.5.0", diff --git a/package.json b/package.json index ee1e09c1d..ad70deece 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "@octokit/auth-action": "^5.0.0", "@octokit/auth-app": "^7.0.0", "@octokit/auth-oauth-app": "^8.0.0", - "@octokit/tsconfig": "^3.0.0", + "@octokit/tsconfig": "^4.0.0", "@sinonjs/fake-timers": "^13.0.0", "@types/jest": "^29.0.0", "@types/lolex": "^5.1.0",