Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: appId argument can be set to Client ID string #606

Merged
merged 7 commits into from
May 9, 2024
Merged

feat: appId argument can be set to Client ID string #606

merged 7 commits into from
May 9, 2024

Commits on May 8, 2024

  1. feat(types): appId allows string or number as type

    @oscard0m
    oscard0m committed May 8, 2024
    Configuration menu
    Copy the full SHA
    fd669c7 View commit details
    Browse the repository at this point in the history

  2. test(types): add test coverage for appId new type

    @oscard0m
    oscard0m committed May 8, 2024
    Configuration menu
    Copy the full SHA
    02c1b1f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. test(types): use a ClientID format for appId examples

    @oscard0m
    oscard0m committed May 9, 2024
    Configuration menu
    Copy the full SHA
    963b5aa View commit details
    Browse the repository at this point in the history

  2. build(deps): set ^2.2.0 as minimum version for universal-github-app-jwt

    @oscard0m
    oscard0m committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bf7f8a6 View commit details
    Browse the repository at this point in the history

  3. feat(createappauth): remove unnecessary validation of options.appId b… 

    …eing a number
    @oscard0m
    oscard0m committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4496939 View commit details
    Browse the repository at this point in the history

  4. test(createappauth): change modified test description

    @oscard0m
    oscard0m committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c6189b7 View commit details
    Browse the repository at this point in the history

  5. ci(release): testing out-of-the-box support for main branch 

    See https://github.com/semantic-release/semantic-release/pull/1737\#issuecomment-2099674808
    @gr2m
    gr2m committed May 9, 2024
    Configuration menu
    Copy the full SHA
    cbff6c8 View commit details
    Browse the repository at this point in the history