Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octo process traj_transforms #140

Open
Lucky-Light-Sun opened this issue Oct 31, 2024 · 0 comments
Open

octo process traj_transforms #140

Lucky-Light-Sun opened this issue Oct 31, 2024 · 0 comments

Comments

@Lucky-Light-Sun
Copy link

Hello, recently I was reviewing the Octo data processing code and noticed an issue in the traj_transformer, specifically in the chunk part. Could you please check if there might be a minor problem in the code?

As shown in the figure, the relative_goal_timestep may be t - (windowsize - 1) + w + h? t means timestep here, w means the history window position, h means the horizon action postion.

Or maybe I misunderstood. Could you help explain it?

relative_goal_timestep = goal_timestep[:, None, None] - (
        t - (window_size + 1) + w + h       # xyg noted: 这里有点像是 t - (window_size - 1) + w + h ???
    )

image

https://github.com/octo-models/octo/blob/main/octo/data/traj_transforms.py#L84-L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant