Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default ravenjs version is too old and does not stay up to date #6

Closed
sedubois opened this issue Feb 18, 2018 · 2 comments
Closed

default ravenjs version is too old and does not stay up to date #6

sedubois opened this issue Feb 18, 2018 · 2 comments

Comments

@sedubois
Copy link

sedubois commented Feb 18, 2018

Sentry warns that the lib is too old when leaving the default version 3.19.1:

screen shot 2018-02-18 at 15 00 08

A temporary workaround is to override version (currently seems to be 3.22.3), but it will soon be outdated as well, and updating this can't be automated with tools such as renovateapp.com because the plugin is referring to the CDN, not to the NPM dependency.

The ideal would be for the plugin to use the latest version by default. Could using the NPM dependency solve this?

@octalmage
Copy link
Owner

octalmage commented Feb 19, 2018

On my own site I just update the version prop. I added a default to make the plugin easier to use but I think the prop is the way to go. I personally lock dependencies and update them manually.

I'm not against using the NPM version though!

@sedubois
Copy link
Author

Yeah I don't know how to do this but if we could use the NPM dep it should solve the issue nicely (keep version locked, but get an automatic pull request from renovate, greenkeeper or other when newer lib is available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants