-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong version in the 1.0.0 packaged releases #793
Comments
Nice catch here, @k2niner. Thanks for bringing it up in our sync yesterday. I don't think it is breaking for the creation of OCSF documents, but it may cause an issue when building a v1 server and could theoretically cause downstream issues for anyone utilizing that file. @rmouritzen-splunk I looked at this a little bit, but am unsure of the best course of action. Since a tag is just a commit, I don't think it is as easy as just updating the version. If i understand, this could be immutable. |
I looked at this once more. Perhaps there is still a way to approach this. Since there is also a v1 branch, and the v1 branch indeed has the correct We can try out a diff between the v1 branch and v1 tagged release - if this is the only difference, then I think we will be safe to delete the old v1 tagged commit and create a new one from the v1 branch. |
Update: Looks like there are only two very small non-breaking changes between this build - an attribute description, and the update of the version from rc3 to v1.0.0. For reference, this is the commit from where the old inaccurate release was cut: 6f73e0e Here is the commit from which I created an accurate v1.0.0 release: 9608805 |
The v1 release has been tested, verified, and updated. Here is the link: https://github.com/ocsf/ocsf-schema/releases/tag/v1.0.0 |
Releases here: https://github.com/ocsf/ocsf-schema/releases/tag/v1.0.0
contain the following version.json:
The text was updated successfully, but these errors were encountered: