Enhancement in ocp-vpa-operator role

[swapnil-bobade27]

The current automation is not cleaning up the resources properly before installing the operator freshly.
The deployment is getting failed to install the operator -

TASK [ocp-vpa-operator : Verify the operator installation] ***************************************************************************************************************
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (15 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (14 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (13 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (12 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (11 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (10 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (9 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (8 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (7 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (6 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (5 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (4 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (3 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (2 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify the operator installation (1 retries left).

TASK [ocp-vpa-operator : Verify pods count] ******************************************************************************************************************************
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify pods count (15 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify pods count (14 retries left).
FAILED - RETRYING: [swap-418-rc1-bastion-0]: Verify pods count (13 retries left).

Suggestion

While installing the operator, the script (tasks/main.yaml line#34) is looking for operator name as verticalpodautoscaler but the operator is getting installed with name - vertical-pod-autoscaler.
So, can we use vertical-?pod-?autoscaler in the script instead of verticalpodautoscaler

- name: Get the installed ClusterServiceVersion of VPA 
  shell: oc get csv -n openshift-vertical-pod-autoscaler --no-headers | awk '{ if ($1 ~ /^verticalpodautoscaler/) print $1 }'
  register: installed_csv

and, for (tasks/main.yaml line#172), the condition should be vpa_service.stdout|int == 2 instead of vpa_service.stdout|int == 1

# oc get service -n openshift-vertical-pod-autoscaler --no-headers
vpa-metrics-service   ClusterIP   172.30.46.17     <none>   8443/TCP   9m26s
vpa-webhook           ClusterIP   172.30.183.168   <none>   443/TCP    8m58s