Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a blank line to be swallowed by the spinner #646

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: add a blank line to be swallowed by the spinner #646

merged 2 commits into from
Oct 13, 2023

Conversation

WillieRuemmele
Copy link
Contributor

@W-14208351@

the spinner is still eating the last line printed before it stops... but to fix it in plugin-update we'll print a sacrificial line to be eaten by the spinner

oclif/core#799

mdonnalley
mdonnalley previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mdonnalley mdonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only suggestion is to put a link to the oclif/core issue in the comment

@WillieRuemmele WillieRuemmele merged commit 2caf5c7 into main Oct 13, 2023
8 checks passed
@WillieRuemmele WillieRuemmele deleted the wr/spinner-eats-logs branch October 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonnalley mdonnalley mdonnalley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillieRuemmele @mdonnalley