Fallback to templates for s3 gz url and baseDir #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amphro
approved these changes
Oct 24, 2018
jdx
approved these changes
Oct 24, 2018
oclif-bot
added a commit
that referenced
this pull request
Oct 24, 2018
## [1.3.5](v1.3.4...v1.3.5) (2018-10-24) ### Bug Fixes * Fallback to templates for s3 gz url and baseDir ([#46](#46)) ([bd7ab36](bd7ab36))
|
🎉 This PR is included in version 1.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us (sfdx) to continue to update in the style we were using under cli-engine, where the manifest did not contain the tarball download urls. This is important to us since our staging s3 is hosted internally and we point the updater at the staging s3 using an environment variable. When we promote a release to the public s3, we simply copy all tarballs, installers, and manifest from the internal s3 to the public one, so it works better for us to be able to derive the full update site urls at runtime rather than from the manifest files.