New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow arg to be empty string #983

Merged

shetzel merged 1 commit into main from mdonnalley/empty-string-arg

Mar 4, 2024

Contributor

mdonnalley commented Mar 1, 2024

Allow args to be an empty string, e.g. my-cli hello ''

Fixes #982
@W-15161625@


          fix: allow arg to be empty string

629d482

shetzel approved these changes

View reviewed changes

Contributor

shetzel commented Mar 4, 2024

QA looks good:

bin/run.js hello '' -f me
 ›   Error: Unexpected argument:
 ›   See more help with --help

yarn link "@oclif/core"
yarn link v1.22.21
success Using linked package for "@oclif/core".

bin/run.js hello '' -f me
hello  from me! (./src/commands/hello/index.ts)

shetzel merged commit 1cfbf17 into main

70 checks passed

shetzel deleted the mdonnalley/empty-string-arg branch

March 4, 2024 21:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet