Use typescript's tsconfig.json parsing functionality instead of JSON.parse

[samuela]

JSON.parse differs from the semantics of typescript's parsing, as JSON.parse doesn't support comments. This PR switches to using typescript's provided parsing functionality for compatibility.

Tests pass with the exception of "tsPath should use the provided esModuleInterop option". For some reason, fancy.stub() doesn't seem to be working: The tests are still calling the unpatched version. I've tried stub() both on a global imported version of "../src/ts-node" and the "freshRequired" versions. Do let me know if I'm doing something wrong here...

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @samuela to sign the Salesforce.com Contributor License Agreement.

[samuela]

cc @jdxcode

[jdx]

off-hand, I'm not really sure why this isn't working. The freshRequire() bit is a little strange though, that shouldn't be necessary. I would try to do it the same way as before without trying to scope it to .add() maybe

[samuela]

@jdxcode freshRequire() was in the original test suite, so I just presumed that it served some useful purpose here. I can try without though.

[jdx]

apologies this turned into such a mess, I might be able to take a look later this week if nothing else

[samuela]

@jdxcode Here are the results when importing a single global ../src/ts-node and then stubbing that:

  1) tsPath
       should leave esModuleInterop undefined by default:

      AssertionError: expected 0 to equal 1
      + expected - actual

      -0
      +1
      
      at Context.withMockTsConfig.it (test/ts-node.test.ts:47:53)
      at Object.run (node_modules/fancy-test/lib/base.js:27:38)
      at Context.run (node_modules/fancy-test/lib/base.js:50:36)

  2) tsPath
       should use the provided esModuleInterop option:

      AssertionError: expected 0 to equal 1
      + expected - actual

      -0
      +1
      
      at Context.withMockTsConfig.it (test/ts-node.test.ts:60:53)
      at Object.run (node_modules/fancy-test/lib/base.js:27:38)
      at Context.run (node_modules/fancy-test/lib/base.js:50:36)

[samuela]

Ok, I tried stubbing out the function with proxyquire but even that isn't working now: thlorenz/proxyquire#236.

[codecov]

Codecov Report

Merging #70 into master will decrease coverage by 68.6%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #70       +/-   ##
========================================
- Coverage    68.6%    0%   -68.61%     
========================================
  Files           7     2        -5     
  Lines         430    10      -420     
  Branches      120     3      -117     
========================================
- Hits          295     0      -295     
+ Misses         87    10       -77     
+ Partials       48     0       -48

Impacted Files	Coverage Δ
src/index.ts	0% <0%> (-100%)	⬇️
src/debug.ts	0% <0%> (-40%)	⬇️
src/plugin.ts
src/config.ts
src/command.ts

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5718233...3e32263. Read the comment docs.

[samuela]

@jdxcode Ok, fixed the failing test. Now codecov is complaining but I don't think I did anything wrong there...

[jdx]

looks good to me! thanks so much!