Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotstart ramp fix #61

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add hotstart ramp fix #61

merged 1 commit into from
Aug 9, 2024

Conversation

SorooshMani-NOAA
Copy link
Collaborator

@SorooshMani-NOAA SorooshMani-NOAA commented Aug 9, 2024

This update was missed when working on the #51 PR. This resulted in confusion and bad ROC results in https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/542

@FariborzDaneshvar-NOAA after this merge let's try installing the latest main again and see how the results look like. Sorry about this!

@SorooshMani-NOAA
Copy link
Collaborator Author

SorooshMani-NOAA commented Aug 9, 2024

In the project definition the follow versions are pinned:

  • stormevents==2.2.5: in order to get speed and quadrant fixes without the rmax forecast. After Enable rmax persistent vs per isotach perturbation #60 this should change to >=2.2.5 (later we need to have option to have rmax forecast using the old -fixed- or new -interpolated- approach)
  • ensembleperturbation==1.2.10: in order to have all the latest package compatibility (geopandas, etc.) without the rmax perturbation updates (where the old perturbation method is not called "persistent". After Enable rmax persistent vs per isotach perturbation #60 this should change to >=1.3

@SorooshMani-NOAA SorooshMani-NOAA merged commit a3141b8 into main Aug 9, 2024
@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/hotstart branch August 9, 2024 13:13
@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Aug 9, 2024
@SorooshMani-NOAA
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant