from_nhc_code bug for same-year events with the same name

[SorooshMani-NOAA]

Try:

storm = stormevents.StormEvent.from_nhc_code('EP182022')

Now if you inspect the storm, it's actually picking Julia from AL basin! That's because of search-by-name done in the constructor and then picking the "first" occurrence of the name in the list:

StormEvents/stormevents/stormevent.py

Lines 76 to 79 in 9cb5d77

	storms = nhc_storms(year=year)
	storms = storms[storms["name"].str.contains(name.upper())]
	if len(storms) > 0:
	self.__entry = storms.iloc[0]

Looking at the storms list from 2022:

           name class  year basin  number       source start_date            end_date
nhc_code
.
.
.
AL132022  JULIA    HU  2022    AL      13  GIS_ARCHIVE        NaT                 NaT
.
.
.
EP182022  JULIA    HU  2022    EP      18              2022-10-02 2022-10-10 18:00:00
.
.
.

[SorooshMani-NOAA]

We need to re-enable the test for status of storm after fixing this ticket. The commented out test that was failing is:

StormEvents/tests/test_stormevent.py

Lines 216 to 233 in 02d6c6a

	# TODO: fails due to issue #78
	# How could it pass before in early 2023?!
	# storms = nhc_storms()
	# latest_storm_entry = storms[
	# ((storms["class"] == "HU") | (storms["class"] == "TS"))
	# & (storms["number"] < 60)
	# ].iloc[-1]
	# latest_storm = StormEvent.from_nhc_code(latest_storm_entry.name)
	# age = datetime.today() - latest_storm_entry["end_date"]
	# if pandas.isna(latest_storm_entry["end_date"]) or age < timedelta(days=1):
	# if datetime.today() - latest_storm_entry["start_date"] > timedelta(days=30):
	# assert latest_storm.status == StormStatus.HISTORICAL
	# else:
	# assert latest_storm.status == StormStatus.REALTIME
	# else:
	# assert latest_storm.status == StormStatus.HISTORICAL

This issue started showing up in April 2023 during #79 for Hurricane Julia (latest 2022 HU storm)

[zacharyburnett]

Ah, that's a blunder 😅 I forgot to account for two storms with the same name in the same year in different basins