Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with WP Statuses #97

Open
rodrigo-arias opened this issue Apr 9, 2021 · 1 comment
Open

Conflict with WP Statuses #97

rodrigo-arias opened this issue Apr 9, 2021 · 1 comment

Comments

@rodrigo-arias
Copy link

rodrigo-arias commented Apr 9, 2021

Hi,

Thanks for your work with Public Post Preview.

I’m started to using it along with WP Statuses (https://github.com/imath/wp-statuses).

That changes things a bit since in the gutenberg-integration.js script when you use getEditedPostAttribute, WP Statuses returns private as status for all statuses, but adds a custom_status attribute that has the correct values.

status: getEditedPostAttribute( 'status' ),

Do you think it is possible to somehow filter the attribute to use, or add some conditional so that the Public Post Preview works with WP Statuses?

Thanks

@claytoncollie
Copy link

We made a fork and fixed the issue for us. It seems like a fundamental change and one that maybe should be better accommodated for in WP Statuses. I am leaving our fix here in case anybody else needs it. @ocean90 If you can think of a workaround, I would be glad to submit a PR.

https://github.com/content-pilot/public-post-preview/blob/160933ee519eca1d0fc921fad0331d997a09e8cc/js/src/components/preview-toggle/index.js#L229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants