Define CLICOLOR_FORCE=1 env var in CI runs
#631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
define-CLICOLOR_FORCE-true
branch
from
7fc81d3
to
299cee2
Compare
|
@smorimoto how do I rebuild the action to make the CI succeed? |
MisterDA
force-pushed
the
define-CLICOLOR_FORCE-true
branch
from
38e70bd
to
c528145
Compare
smorimoto
force-pushed
the
define-CLICOLOR_FORCE-true
branch
from
c528145
to
dc63bf0
Compare
smorimoto
reviewed
Nov 7, 2022
|
Could you add a changelog entry? |
This env var is supported by some tools to force them to emit ANSI escape sequences corresponding to colors even if they detect that they're not running in tty, which is th case for CI jobs. It is going to be supported in Dune 3.6.0, and perhaps other compilers and build systems. Signed-off-by: Antonin Décimo <[email protected]>
MisterDA
force-pushed
the
define-CLICOLOR_FORCE-true
branch
from
dc63bf0
to
03f6cce
Compare
|
I've applied your suggestion, added a changelog entry, and rebuild the action. |
|
Dune 3.6 was just released with support for this feature! |
Signed-off-by: Antonin Décimo <[email protected]>
smorimoto
force-pushed
the
define-CLICOLOR_FORCE-true
branch
from
03f6cce
to
a4ba71f
Compare
smorimoto
approved these changes
Nov 26, 2022
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 30, 2022
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 30, 2022
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 30, 2022
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 30, 2022
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 30, 2022
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Nov 30, 2022
* Set CLICOLOR_FORCE=0 Since #6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as #6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
moyodiallo
pushed a commit
to moyodiallo/dune
that referenced
this pull request
Dec 2, 2022
* Set CLICOLOR_FORCE=0 Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This env var is supported by some tools to force them to emit ANSI escape sequences corresponding to colors even if they detect that they're not running in tty, which is th case for CI jobs.
It is going to be supported in Dune 3.6.0, and perhaps other compilers and build systems.