Merge pull request #891 from ocaml/post-step-should-not-fail

The post step should not fail if there is an error
ocaml · Nov 9, 2024 · bd18776 · bd18776
2 parents 6b1537a + e7e0930
commit bd18776
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 18 deletions.
diff --git a/analysis/dist/index.js b/analysis/dist/index.js
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/post/index.js b/dist/post/index.js
diff --git a/lint-doc/dist/index.js b/lint-doc/dist/index.js
diff --git a/lint-fmt/dist/index.js b/lint-fmt/dist/index.js
diff --git a/lint-opam/dist/index.js b/lint-opam/dist/index.js
diff --git a/packages/analysis/src/index.ts b/packages/analysis/src/index.ts
@@ -11,7 +11,7 @@ async function run() {
     process.exit(0);
   } catch (error) {
     if (error instanceof Error) {
-      core.setFailed(error.message);
+      core.error(error.message);
     }
     process.exit(1);
   }

diff --git a/packages/lint-doc/src/index.ts b/packages/lint-doc/src/index.ts
@@ -11,7 +11,7 @@ async function run() {
     process.exit(0);
   } catch (error) {
     if (error instanceof Error) {
-      core.setFailed(error.message);
+      core.error(error.message);
     }
     process.exit(1);
   }

diff --git a/packages/lint-fmt/src/index.ts b/packages/lint-fmt/src/index.ts
@@ -15,7 +15,7 @@ async function run() {
     process.exit(0);
   } catch (error) {
     if (error instanceof Error) {
-      core.setFailed(error.message);
+      core.error(error.message);
     }
     process.exit(1);
   }

diff --git a/packages/lint-opam/src/index.ts b/packages/lint-opam/src/index.ts
@@ -12,7 +12,7 @@ async function run() {
     process.exit(0);
   } catch (error) {
     if (error instanceof Error) {
-      core.setFailed(error.message);
+      core.error(error.message);
     }
     process.exit(1);
   }

diff --git a/packages/setup-ocaml/src/cache.ts b/packages/setup-ocaml/src/cache.ts
@@ -127,7 +127,7 @@ async function restoreCache(
     if (error instanceof Error) {
       core.info(error.message);
     }
-    core.warning(
+    core.notice(
       "An internal error has occurred in cache backend. Please check https://www.githubstatus.com for any ongoing issue in actions.",
     );
     return;
@@ -145,7 +145,7 @@ async function saveCache(key: string, paths: string[]) {
     if (error instanceof Error) {
       core.info(error.message);
     }
-    core.warning(
+    core.notice(
       "An internal error has occurred in cache backend. Please check https://www.githubstatus.com for any ongoing issue in actions.",
     );
   }

diff --git a/packages/setup-ocaml/src/index.ts b/packages/setup-ocaml/src/index.ts
@@ -8,7 +8,7 @@ async function run() {
     process.exit(0);
   } catch (error) {
     if (error instanceof Error) {
-      core.setFailed(error.message);
+      core.error(error.message);
     }
     process.exit(1);
   }

diff --git a/packages/setup-ocaml/src/post.ts b/packages/setup-ocaml/src/post.ts
@@ -15,7 +15,8 @@ async function run() {
     if (error instanceof Error) {
       core.error(error.message);
     }
-    process.exit(1);
+    // The post step should not fail if there is an error...
+    process.exit(0);
   }
 }