deprecated syntax removed #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://fishshell.com/docs/current/index.html#id4 "Previous versions of fish also allowed specifying this as ^DESTINATION, but that made another character special so it was deprecated and will be removed in the future." fish version 3.3.0 by default gives an error on old syntax
|
Thanks for the update. Does |
|
I am a relatively new fish user and not sure about older versions. However, from the comment in their documentation, it seems it was supported all along with ^ being just a shortcut which they deprecated. |
rjbou
approved these changes
Jun 30, 2021
|
tested with fish 3.1.2, and seems ok. |
|
This seems worth backporting to 2.0.9 and 2.1.0 as well. In fact, I found this after updating fish today and reinit didn't fix the error, so I got here. |
This was referenced Jul 3, 2021
rjbou
added a commit
that referenced
this pull request
Jul 19, 2021
Backport #4736 to the 2.0 branch
rjbou
added a commit
that referenced
this pull request
Jul 20, 2021
Backport #4736 to the 2.1 branch: fix fish deprecated syntax
|
@kit-ty-kate Thanks for the backport! Could you just fix your comment "4743 and 4743" to "4743 and 4744" for easy reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://fishshell.com/docs/current/index.html#id4
"Previous versions of fish also allowed specifying this as ^DESTINATION, but that made another character special so it was deprecated and will be removed in the future."
fish version 3.3.0 by default gives an error on old syntax