Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global variables should not shadow options #4730

Closed
dra27 opened this issue Jun 25, 2021 · 1 comment · Fixed by #4904
Closed

Global variables should not shadow options #4730

dra27 opened this issue Jun 25, 2021 · 1 comment · Fixed by #4904
Assignees
@rjbou
Labels
AREA: UI
Milestone
2.3.0~alpha1

Comments

@dra27
Copy link
Member

dra27 commented Jun 25, 2021

opam var --global jobs=42 sets the global variable jobs which creates a strange state for opam in that the jobs variable is now 42 but opam will only schedule up to the previous value of jobs.

The correct course of action here is opam option jobs=42 - opam var should not permit shadowing the options.
@dra27 dra27 added this to the 2.2.0~alpha milestone Jun 25, 2021
@dra27
Copy link
Member Author

dra27 commented Jun 25, 2021

(this is a "maybe" for 2.2, at least for me...)

@rjbou rjbou self-assigned this Jul 2, 2021
@dra27 dra27 added the AREA: UI label Jul 16, 2021
@rjbou rjbou mentioned this issue Nov 10, 2021
Merged
@rjbou rjbou modified the milestones: 2.2.0~alpha, 2.3 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjbou rjbou

Labels
AREA: UI
Projects
None yet
Milestone
2.3.0~alpha1
Development

Successfully merging a pull request may close this issue.

Warn when setting a variable that shadow an option rjbou/opam
2 participants
@dra27 @rjbou