Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the conflict with the environment variable name used by dune #4535

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Feb 8, 2021

As the title says. This is a bug that was found while investigating ocaml/dune#4166.

Related issue: #4068

@rjbou rjbou added the KIND: BUG label Feb 9, 2021
@rjbou rjbou added this to the 2.1.0~beta5 milestone Feb 12, 2021
@rjbou rjbou merged commit 42cc951 into ocaml:master Feb 12, 2021
@rjbou
Copy link
Collaborator

rjbou commented Feb 12, 2021

Thanks!

@rjbou
Copy link
Collaborator

rjbou commented Feb 12, 2021

PR to backport in 2.0.9

@smorimoto smorimoto deleted the fix-dune-cache branch February 12, 2021 17:45
@smorimoto
Copy link
Member Author

Thank you, too! Is there a timeline for the 2.0.9 release btw?

@rjbou
Copy link
Collaborator

rjbou commented Feb 12, 2021

The list of backported PRs/fixes is done on the fly, regarding the needs. (and no date set for 2.0.9 yet).

@rjbou rjbou mentioned this pull request Feb 12, 2021
2 tasks
@smorimoto
Copy link
Member Author

Got it, 2.1.0 doesn't seem to be released as early as I thought, so it would be helpful if 2.0.9 be released as soon as possible. (Because once put this change into the stable release, setup-ocaml can use the dune cache to speed up the entire workflow a couple of times.)

@rjbou
Copy link
Collaborator

rjbou commented Feb 12, 2021

Ok, noted!

@smorimoto
Copy link
Member Author

But definitely there is no rush at all. Please release it at your convenience. Thanks for your effort on opam :)

@rjbou
Copy link
Collaborator

rjbou commented Feb 12, 2021

Until the release, you can change the sandbox file. It is in ~/.opam/opam-init/hooks/sandbox.sh (or sed it if in stateless scripty).

@smorimoto
Copy link
Member Author

Indeed, I don't really like doing that kind of hack on the action side, but let me create another branch and check it if it works as expected.

@smorimoto
Copy link
Member Author

OK, I replaced the file and it works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants