-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the conflict with the environment variable name used by dune #4535
Conversation
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]> Co-Authored-By: Kate <[email protected]>
Thanks! |
PR to backport in 2.0.9 |
Thank you, too! Is there a timeline for the 2.0.9 release btw? |
The list of backported PRs/fixes is done on the fly, regarding the needs. (and no date set for 2.0.9 yet). |
Got it, 2.1.0 doesn't seem to be released as early as I thought, so it would be helpful if 2.0.9 be released as soon as possible. (Because once put this change into the stable release, setup-ocaml can use the dune cache to speed up the entire workflow a couple of times.) |
Ok, noted! |
But definitely there is no rush at all. Please release it at your convenience. Thanks for your effort on opam :) |
Until the release, you can change the sandbox file. It is in |
Indeed, I don't really like doing that kind of hack on the action side, but let me create another branch and check it if it works as expected. |
OK, I replaced the file and it works as expected! |
As the title says. This is a bug that was found while investigating ocaml/dune#4166.
Related issue: #4068