Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ocaml-jupyter 1.0.0 #10071

Merged
merged 2 commits into from
Sep 2, 2017
Merged

Release ocaml-jupyter 1.0.0 #10071

merged 2 commits into from
Sep 2, 2017

Conversation

akabe
Copy link
Contributor

@akabe akabe commented Aug 11, 2017

@camelus
Copy link
Contributor

camelus commented Aug 11, 2017

✅ All lint checks passed 90717c1
  • These packages passed lint tests: jupyter.1.0.0, jupyter.1.0.1

✅ Installability check (7351 → 7353)
  • new installable packages (2): jupyter.1.0.0 jupyter.1.0.1

@akabe
Copy link
Contributor Author

akabe commented Aug 11, 2017

This package depends on cppo ocamlbuild plugin, but it will be split into cppo and cppo_ocamlbuild: #10047 . Could you merge this PR after release of the new version of cppo? I need to add "cppo_ocamlbuild" {build} line to opam file.

@avsm
Copy link
Member

avsm commented Aug 11, 2017

Sure; when #10047 is merged, you will need to merge you branch with the master branch of opam-repository as well so that it picks up the new packages

@dbuenzli
Copy link
Contributor

Ping @akabe, #10047 has been merged, please rebase.

@akabe
Copy link
Contributor Author

akabe commented Aug 24, 2017

@dbuenzli Thanks for notification. I rebased the current master to this branch.

@akabe
Copy link
Contributor Author

akabe commented Aug 24, 2017

Hmm. It seems that ppx_deriving_yojson doesn't support OCaml 4.05+.

@akabe
Copy link
Contributor Author

akabe commented Aug 24, 2017

@whitequark ppx_deriving_yojson.3.0 cannot be built in OCaml 4.05 due to incompatible data parse tree with OCaml 4.04 or below, reported at ocaml-ppx/ppx_deriving_yojson#56. I added ocaml-version < "4.05.0" condition to the opam file of ppx_deriving_yojson.3.0.

@akabe
Copy link
Contributor Author

akabe commented Aug 28, 2017

@avsm @dbuenzli Thanks for waiting. I added cppo_ocamlbuild and rebased the current master branch. Please merge this PR.

@akabe
Copy link
Contributor Author

akabe commented Sep 1, 2017

@avsm @dbuenzli Ping. Please merge this PR if it has no problem.

@dbuenzli
Copy link
Contributor

dbuenzli commented Sep 1, 2017

I'll let @avsm do this. I don't do merges.

@avsm avsm merged commit 30e800f into ocaml:master Sep 2, 2017
@avsm
Copy link
Member

avsm commented Sep 2, 2017

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

@akabe akabe deleted the jupyter.1.0.0 branch September 5, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants