Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussing the release of a loc package #26604

Closed
mbarbin opened this issue Sep 23, 2024 · 3 comments
Closed

Discussing the release of a loc package #26604

mbarbin opened this issue Sep 23, 2024 · 3 comments

Comments

@mbarbin
Copy link
Contributor

mbarbin commented Sep 23, 2024

I am using a type to represent a range of lexing positions from a file, which I called Loc.t. It's here.

I use it as dependency to decorate AST nodes built by parsers, enabling located error messages during file processing (compilers, interpreters, linters, refactor tools, etc.).

I am considering submitting it to the opam-repository, but I have some reservations.

  • Firstly I am unsure how to package it for publication. Would there be push-back about grabbing the global "loc" name on opam?
  • Secondly, this is very similar to Dune's Stdune.Loc module (and actually uses stdune under the hood). Perhaps it would make more sense to work on extracting the Dune one as a foundational package (such as pp, dyn, and ordering), rather than maintaining this one separately.

My motivation is that I have other libraries that I'd like to eventually publish to opam that depend on it. Some examples below:

Similar libraries or modules:

I would appreciate any thoughts or feedback on this matter. Thank you!

@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 23, 2024

I've asked the question about Dune to the Dune devs here ocaml/dune#10948

@avsm
Copy link
Member

avsm commented Sep 26, 2024

Thanks for all your work in establishing consensus here, @mbarbin. From the opam-repo perspective, we have no objection...

@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 27, 2024

Thank you. With this feedback, I feel comfortable opening #26625 for review.

I will be closing this issue then, the Dune discussion part can stay open as needed.

Thanks a lot!

@mbarbin mbarbin closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants