Some x-ci-accept-failures appears to be ignored

[thierry-martinez]

Failures in #19824 are marked as x-ci-accept-failures, but surprisingly the grep on this field at the end of the CI script seems to miss them and still reports them as CI errors.

[thierry-martinez]

The script executed by opam-ci only considers x-ci-accept-failures when opam fails with error-code 31 (line test "$res" != 31 && exit "$res";), which corresponds (according to opam --help) to Package script error.. However, in the case of #19824, the error is triggered by opam remove for a dependency problem, and opam fails with error-code 5 (Not found.).

It seems to me that considering x-ci-accept-failures in this case would make sense: why restricting x-ci-accept-failures to error code 31? Could it be applied at least for error code 5 as well?

[thierry-martinez]

The error-code returned by opam is erroneous and is reported in ocaml/opam#4890 . The lack of covering of x-ci-accept-failures is handled here: ocaml/opam#4493 (thank you @kit-ty-kate for pointing this). Two open issues for this problem seems enough and I close this third one!