TUI (no nottui) #8430
Closed
TUI (no nottui) #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
The help screen can be toggled on and off. The scroll bars appear when the main text is cut off in the horizontal or vertical directions. They can be interacted with using the arrow keys, j and k and using the mouse. The mouse can scroll and click on them. Added a utility to provide debug info, which can be useful determining the state of the UI. It can be activated using 'd'. Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
We improve the logic for scroll handling. Notably now the arrow buttons on the scroll bars work. We also make many of the used style attrubutes internally configurable and fix any styles biased to a dark background. There are various cleanups for the drawing of the top frame, including making the debug info menu a proper overlay rather than just appending to the end. Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
rgrinberg
reviewed
Aug 22, 2023
| let start () = Unix.set_nonblock Unix.stdin | ||
| let term_input_fds, _ = Term.fds (term ()) | ||
|
|
||
| let start () = Unix.set_nonblock term_input_fds |
There was a problem hiding this comment.
That's wrong. You can't do that anymore
There was a problem hiding this comment.
That snuck in during rebase, shouldn't be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP is an alternative to #8429 that doesn't use the nottui additions that were included there.
This is based on notty and we have basic GUI components like pop-up dialogues, scroll bars etc.
There are some issues with this such as resizing causing crashes that need to be resolved.