Do not open the log file in "dune clean" #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2964 Fixes #2921 Signed-off-by: Jeremie Dimino <[email protected]>
rgrinberg
approved these changes
Dec 12, 2019
ghost
merged commit
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Dec 13, 2019
…lugin, dune-private-libs and dune-glob (2.1.0) CHANGES: - Attach cinaps stanza actions to both `@runtest` and `@cinaps` aliases (ocaml/dune#2831, @NathanReb) - Add variables `%{lib-private...}` and `%{libexec-private...}` for finding build paths of files in public and private libraries within the same project. (ocaml/dune#2901, @snowleopard) - Add `--mandir` option to `$ dune install`. This option allows to override the installation directory for man pages. (ocaml/dune#2915, fixes ocaml/dune#2670, @rgrinberg) - Fix `dune --version`. The bootstrap didn't compute the version correctly. (ocaml/dune#2929, fixes ocaml/dune#2911, @diml) - Do not open the log file in `dune clean`. (ocaml/dune#2965, fixes ocaml/dune#2964 and ocaml/dune#2921, @diml) - Support passing two arguments to `=`, `<>`, ... operators in package dependencies so that we can have things such as `(<> :os win32)` (ocaml/dune#2965, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Dec 21, 2019
…lugin, dune-private-libs and dune-glob (2.1.0) CHANGES: - Attach cinaps stanza actions to both `@runtest` and `@cinaps` aliases (ocaml/dune#2831, @NathanReb) - Add variables `%{lib-private...}` and `%{libexec-private...}` for finding build paths of files in public and private libraries within the same project. (ocaml/dune#2901, @snowleopard) - Add `--mandir` option to `$ dune install`. This option allows to override the installation directory for man pages. (ocaml/dune#2915, fixes ocaml/dune#2670, @rgrinberg) - Fix `dune --version`. The bootstrap didn't compute the version correctly. (ocaml/dune#2929, fixes ocaml/dune#2911, @diml) - Do not open the log file in `dune clean`. (ocaml/dune#2965, fixes ocaml/dune#2964 and ocaml/dune#2921, @diml) - Support passing two arguments to `=`, `<>`, ... operators in package dependencies so that we can have things such as `(<> :os win32)` (ocaml/dune#2965, @diml)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2964
Fixes #2921