-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables %{lib-private} and %{libexec-private} #2901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
snowleopard
requested review from
emillon,
nojb and
rgrinberg
as code owners
November 21, 2019 14:01
snowleopard
changed the title
Add %{lib-private} and %{libexec-private} varibles
Add variables %{lib-private} and %{libexec-private}
Nov 21, 2019
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
ghost
reviewed
Nov 21, 2019
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
ghost
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
snowleopard
force-pushed
the
fix-findlib
branch
from
November 21, 2019 17:22
cacf7fd
to
3cb14c7
Compare
aalekseyev
reviewed
Nov 21, 2019
Signed-off-by: Andrey Mokhov <[email protected]>
aalekseyev
approved these changes
Nov 21, 2019
Signed-off-by: Andrey Mokhov <[email protected]>
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Dec 13, 2019
…lugin, dune-private-libs and dune-glob (2.1.0) CHANGES: - Attach cinaps stanza actions to both `@runtest` and `@cinaps` aliases (ocaml/dune#2831, @NathanReb) - Add variables `%{lib-private...}` and `%{libexec-private...}` for finding build paths of files in public and private libraries within the same project. (ocaml/dune#2901, @snowleopard) - Add `--mandir` option to `$ dune install`. This option allows to override the installation directory for man pages. (ocaml/dune#2915, fixes ocaml/dune#2670, @rgrinberg) - Fix `dune --version`. The bootstrap didn't compute the version correctly. (ocaml/dune#2929, fixes ocaml/dune#2911, @diml) - Do not open the log file in `dune clean`. (ocaml/dune#2965, fixes ocaml/dune#2964 and ocaml/dune#2921, @diml) - Support passing two arguments to `=`, `<>`, ... operators in package dependencies so that we can have things such as `(<> :os win32)` (ocaml/dune#2965, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Dec 21, 2019
…lugin, dune-private-libs and dune-glob (2.1.0) CHANGES: - Attach cinaps stanza actions to both `@runtest` and `@cinaps` aliases (ocaml/dune#2831, @NathanReb) - Add variables `%{lib-private...}` and `%{libexec-private...}` for finding build paths of files in public and private libraries within the same project. (ocaml/dune#2901, @snowleopard) - Add `--mandir` option to `$ dune install`. This option allows to override the installation directory for man pages. (ocaml/dune#2915, fixes ocaml/dune#2670, @rgrinberg) - Fix `dune --version`. The bootstrap didn't compute the version correctly. (ocaml/dune#2929, fixes ocaml/dune#2911, @diml) - Do not open the log file in `dune clean`. (ocaml/dune#2965, fixes ocaml/dune#2964 and ocaml/dune#2921, @diml) - Support passing two arguments to `=`, `<>`, ... operators in package dependencies so that we can have things such as `(<> :os win32)` (ocaml/dune#2965, @diml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to find paths to source files of public and private libraries.