Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune should complain if it find "deadcode" in the env stanza #5886

Closed
hhugo opened this issue Jun 15, 2022 · 1 comment · Fixed by #5898 or ocaml/opam-repository#21845
Closed

dune should complain if it find "deadcode" in the env stanza #5886

hhugo opened this issue Jun 15, 2022 · 1 comment · Fixed by #5898 or ocaml/opam-repository#21845
Assignees
@emillon
Milestone
3.4.0

Comments

@hhugo
Copy link
Collaborator

hhugo commented Jun 15, 2022

In the following, <settings> under the name section is "deadcode" because it's always shadowed by the previous _ section.
Dune should warn in this case.

(env
  (_ <settings>)
  (name <settings>))
@hhugo
Copy link
Collaborator Author

hhugo commented Jun 16, 2022

https://gitlab.com/tezos/tezos/-/merge_requests/5580

@emillon emillon self-assigned this Jun 20, 2022
@emillon emillon mentioned this issue Jun 20, 2022
Merged
emillon added a commit to emillon/dune that referenced this issue Jun 20, 2022
@emillon
Env stanza: warn if some rules are ignored
999db90 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jun 27, 2022
@emillon
Env stanza: warn if some rules are ignored
d481c0e 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jun 28, 2022
@emillon
Env stanza: warn if some rules are ignored
1fc45d3 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jul 4, 2022
@emillon
Env stanza: warn if some rules are ignored
c5646bb 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jul 12, 2022
@emillon
Env stanza: warn if some rules are ignored
0b34d35 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jul 20, 2022
@emillon
Env stanza: warn if some rules are ignored
b1068bc 
Since matching is sequential, anything after `_` cannot be reached.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit to emillon/dune that referenced this issue Jul 20, 2022
@emillon
Env stanza: warn if some rules are ignored
a7e4082 
Since matching is sequential, anything after `_` cannot be reached.
This warning is fatal in 3.4.

Closes ocaml#5886

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit that referenced this issue Jul 20, 2022
@emillon
Env stanza: warn if some rules are ignored (#5898)
c6e2773 
Since matching is sequential, anything after `_` cannot be reached.
This warning is fatal in 3.4.

Closes #5886

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon mentioned this issue Jul 20, 2022
Merged
emillon added a commit to emillon/opam-repository that referenced this issue Jul 20, 2022
@emillon
[new release] xdg, stdune, ordering, ocamlc-loc, fiber, dyn, dune, du…
95b4730 
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.4.0)

CHANGES:

- Make `dune describe` correctly handle overlapping implementations
  for virtual libraries (ocaml/dune#5971, fixes ocaml/dune#5747, @esope)

- Building the `@check` alias should make sure the libraries and executables
  don't have dependency cycles (ocaml/dune#5892, @rgrinberg)

- [ctypes] Add support for the `errno` parameter using the `errno_policy` field
  in the ctypes settings. (ocaml/dune#5827, @droyo)

- Fix `dune coq top` when it is invoked on files from a subdirectory of the
  directory containing the associated stanza (ocaml/dune#5784, fixes ocaml/dune#5552, @ejgallego,
  @rlepigre, @Alizter)

- Fix hint when an invalid module name is found. (ocaml/dune#5922, fixes ocaml/dune#5273, @emillon)

- The `(cat)` action now supports several files. (ocaml/dune#5928, fixes ocaml/dune#5795, @emillon)

- Dune no longer uses shimmed `META` files for OCaml 5.x, solely using the ones
  installed by the compiler. (ocaml/dune#5916, @dra27)

- Fix handling of the `(deps)` field in `(test)` stanzas when there is an
  `.expected` file. (ocaml/dune#5952, ocaml/dune#5951, fixes ocaml/dune#5950, @emillon)

- Ignore insignificant filesystem events. This stops RPC in watch mode from
  flashing errors on insignificant file system events such as changes in the
  `.git/` directory. (ocaml/dune#5953, @rgrinberg)

- Fix parsing more error messages emitted by the OCaml compiler. In
  particular, messages where the excerpt line number started with a blank
  character were skipped. (ocaml/dune#5981, @rgrinberg)

- env stanza: warn if some rules are ignored because they appear after a
  wildcard rule. (ocaml/dune#5898, fixes ocaml/dune#5886, @emillon)

- On Windows, XDG_CACHE_HOME is taken to be the `FOLDERID_InternetCache` if
  unset, and XDG_CONFIG_HOME and XDG_DATA_HOME are both taken to be
  `FOLDERID_LocalAppData` if unset.  (ocaml/dune#5943, fixes ocaml/dune#5808, @nojb)
@rgrinberg rgrinberg added this to the 3.4.0 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emillon emillon

Labels
None yet
Projects
None yet
Milestone
3.4.0
3 participants
@rgrinberg @emillon @hhugo