Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting: add a way to override binaries #2498

Closed
emillon opened this issue Aug 2, 2019 · 4 comments
Closed

formatting: add a way to override binaries #2498

emillon opened this issue Aug 2, 2019 · 4 comments

Comments

@emillon
Copy link
Collaborator

emillon commented Aug 2, 2019

As described in #2315, once we have (formatting) we should have a way to override paths to formatting binaries. This might be a workspace option.

@bobot
Copy link
Collaborator

bobot commented Aug 2, 2019

Is it not already possible thanks to (paths in dune-workspace #2426 ?

@emillon
Copy link
Collaborator Author

emillon commented Sep 3, 2019

That's indeed a way to implement it, but I think that the original proposal included things like using a binary named ocamlformat-0.10, for example.

@nojb
Copy link
Collaborator

nojb commented Sep 3, 2019

That's indeed a way to implement it, but I think that the original proposal included things like using a binary named ocamlformat-0.10, for example.

Have you tried with (env (_ (binaries ...))) ?

@rgrinberg
Copy link
Member

We already have a mechanism for overriding binaries as Nicolas mentioned. It can be improved if it doesn't work for this use case.

@rgrinberg rgrinberg closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants