Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam file generation: normalise resulting opam file #2290

Closed
avsm opened this issue Jun 17, 2019 · 1 comment
Closed

opam file generation: normalise resulting opam file #2290

avsm opened this issue Jun 17, 2019 · 1 comment

Comments

@avsm
Copy link
Member

avsm commented Jun 17, 2019

When generating opam files via dune-project, there's a big diff between the default order of opam fields generated by dune and those normalised by opam lint <file> --normalise

This is a minor hassle since the submitted version in dune-release could be run through opam lint before generating the release archive. But if it's easy with the existing opam libraries vendored in dune, it would be nice to have the generated order match the opam linted field order.

@ghost
Copy link

ghost commented Jun 18, 2019

Let's just hard-code the right order. I suppose it's not changing very often.

avsm added a commit to avsm/dune that referenced this issue Jul 8, 2019
The logic for the field order used by `opam lint --normalise`
is in opam-file and not opam-file-format. This is too much to
vendor, so this commit hardcodes the field order based on
the opam-file logic.

It won't change very often upstream so this shouldn't impose
too much of a maintenance overhead.

Closes ocaml#2290

Signed-off-by: Anil Madhavapeddy <[email protected]>
avsm added a commit to avsm/dune that referenced this issue Jul 9, 2019
The logic for the field order used by `opam lint --normalise`
is in opam-file and not opam-file-format. This is too much to
vendor, so this commit hardcodes the field order based on
the opam-file logic.

It won't change very often upstream so this shouldn't impose
too much of a maintenance overhead.

Closes ocaml#2290

Signed-off-by: Anil Madhavapeddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant