You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In practice all of the positional properties (clientX/Y, etc) on pointerEvents are floats, not ints (at least in latest Chrome). In the Dom_html they inherit from mouseEvent, which describes all of these values as ints. In wasm this fails with a cast error (and in javacript obviously there is a loss of precision in the number).
I think the right fix is to update the types, ideally before the float/int breaking change in js_of_ocaml so that folks can migrate both at the same time. Maybe a closer audit of these values would be good to ensure we aren't missing more?
The text was updated successfully, but these errors were encountered:
In practice all of the positional properties (
clientX/Y
, etc) onpointerEvent
s are floats, not ints (at least in latest Chrome). In theDom_html
they inherit frommouseEvent
, which describes all of these values as ints. In wasm this fails with a cast error (and in javacript obviously there is a loss of precision in the number).I think the right fix is to update the types, ideally before the float/int breaking change in js_of_ocaml so that folks can migrate both at the same time. Maybe a closer audit of these values would be good to ensure we aren't missing more?
The text was updated successfully, but these errors were encountered: