Fix issues at runtime when the Pervasives module is redefined #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
added a commit
to kit-ty-kate/opam-repository
that referenced
this pull request
Nov 6, 2020
CHANGES:
* Update to ppx_deriving 5.0 and ppxlib
(ocaml-ppx/ppx_deriving_yojson#121)
Rudi Grinberg, Thierry Martinez, Kate Deplaix and Gabriel Scherer
* Fix issues when the equality operator `(=)` is shadowed
(ocaml-ppx/ppx_deriving_yojson#126, ocaml-ppx/ppx_deriving_yojson#128, fixes ocaml-ppx/ppx_deriving_yojson#79)
Martin Slota, Kate Deplaix
|
This breaks frama-c. I reverted the releases and currently looking for a fix |
kit-ty-kate
added a commit
to kit-ty-kate/ppx_deriving_yojson
that referenced
this pull request
Nov 7, 2020
kit-ty-kate
added a commit
to kit-ty-kate/opam-repository
that referenced
this pull request
Nov 7, 2020
CHANGES:
* Update to ppx_deriving 5.0 and ppxlib
(ocaml-ppx/ppx_deriving_yojson#121)
Rudi Grinberg, Thierry Martinez, Kate Deplaix and Gabriel Scherer
* Fix issues when the equality operator `(=)` is shadowed
(ocaml-ppx/ppx_deriving_yojson#126, ocaml-ppx/ppx_deriving_yojson#128, fixes ocaml-ppx/ppx_deriving_yojson#79)
Martin Slota, Kate Deplaix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the changelog for the release I realized that my modification of #126 isn't correct if the user has redefined/shadowed the
Pervasivesmodule.Previously, only a handful of modules exported by
Ppx_deriving_runtimewere reexported byPpx_deriving_yojson_runtime, with this change the whole interface is being pulled up.