Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eio shouldn't set socket SO_REUSEPORT and SO_REUSEADDR options when creating sockets #362

Closed
bikallem opened this issue Nov 3, 2022 · 2 comments
Closed

Eio shouldn't set socket SO_REUSEPORT and SO_REUSEADDR options when creating sockets #362

bikallem opened this issue Nov 3, 2022 · 2 comments

Comments

@bikallem
Copy link
Contributor

bikallem commented Nov 3, 2022 •
edited
Loading

(Aside: why is SO_REUSEPORT on by default? That seems like a dangerous option, allowing two programs to listen on the same port by mistake! )

Based on discussion at #360 (comment)_, eio shouldn't set SO_RESUSEPORT and SO_REUSEADDR option when creating sockets. This is for both TCP and UDP sockets.

Possibly related to #322
@bikallem bikallem mentioned this issue Nov 3, 2022
Merged
@bikallem
Copy link
Contributor Author

bikallem commented Nov 4, 2022

@talex5 @haesbaert I think it is better if eio doesn't set these options on socket (both TCP and UDP) during creation. Doing so would be surprising since it is not the norm I believe. It would be better to provide an API which allows users to do so, wdyt?

@bikallem
Copy link
Contributor Author

bikallem commented Nov 4, 2022

Closing this since #360 fixes it.

@bikallem bikallem closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bikallem