Fix try region closure for "match with exception" under Flambda 2 (#1339

)

Co-authored-by: Vincent Laviron <[email protected]>

middle_end/flambda2/from_lambda/lambda_to_flambda.ml

@@ -27,7 +27,11 @@ module Function_decl = Closure_conversion_aux.Function_decls.Function_decl
 module Env : sig
   type t
 
-  type region_stack_element
+  type region_stack_element = private
+    | Regular of Ident.t
+    | Try_with of Ident.t
+
+  val same_region : region_stack_element -> region_stack_element -> bool
 
   val create :
     current_unit:Compilation_unit.t ->
@@ -152,7 +156,8 @@ module Env : sig
   (** Hack for staticfail (which should eventually use
       [pop_regions_up_to_context]) *)
   val pop_region :
-    region_stack_element list -> (Ident.t * region_stack_element list) option
+    region_stack_element list ->
+    (region_stack_element * region_stack_element list) option
 
   val pop_regions_up_to_context : t -> Continuation.t -> Ident.t option
 
@@ -172,6 +177,12 @@ end = struct
     | Regular of Ident.t
     | Try_with of Ident.t
 
+  let same_region region1 region2 =
+    match region1, region2 with
+    | Regular _, Try_with _ | Try_with _, Regular _ -> false
+    | Regular id1, Regular id2 | Try_with id1, Try_with id2 ->
+      Ident.same id1 id2
+
   type t =
     { current_unit : Compilation_unit.t;
       current_values_of_mutables_in_scope :
@@ -407,7 +418,7 @@ end = struct
 
   let pop_region = function
     | [] -> None
-    | (Try_with region | Regular region) :: rest -> Some (region, rest)
+    | ((Try_with _ | Regular _) as region) :: rest -> Some (region, rest)
 
   let pop_regions_up_to_context t continuation =
     let initial_stack_context = region_stack_in_cont_scope t continuation in
@@ -535,32 +546,36 @@ let compile_staticfail acc env ccenv ~(continuation : Continuation.t) ~args :
        allocation region"
       Continuation.print continuation;
   let rec add_end_regions acc ~region_stack_now =
-    (* CR pchambart: this probably can't be exercised right now, no lambda
-       jumping through a region seems to be generated. *)
+    (* This can maybe only be exercised right now using "match with exception",
+       since that causes jumps out of try-regions (but not normal regions). *)
     (* CR pchambart: This closes all the regions between region_stack_now and
        region_stack_at_handler, but closing only the last one should be
        sufficient. *)
-    let add_end_region region ~region_stack_now after_everything =
+    let add_end_region (region : Env.region_stack_element) ~region_stack_now
+        after_everything =
       let add_remaining_end_regions acc =
         add_end_regions acc ~region_stack_now
       in
       let body = add_remaining_end_regions acc after_everything in
       fun acc ccenv ->
-        CC.close_let acc ccenv
-          (Ident.create_local "unit")
-          Not_user_visible Flambda_kind.With_subkind.tagged_immediate
-          (End_region region) ~body
+        match region with
+        | Try_with _ -> body acc ccenv
+        | Regular region_ident ->
+          CC.close_let acc ccenv
+            (Ident.create_local "unit")
+            Not_user_visible Flambda_kind.With_subkind.tagged_immediate
+            (End_region region_ident) ~body
     in
     let no_end_region after_everything = after_everything in
     match
       Env.pop_region region_stack_now, Env.pop_region region_stack_at_handler
     with
     | None, None -> no_end_region
     | Some (region1, region_stack_now), Some (region2, _) ->
-      if Ident.same region1 region2
+      if Env.same_region region1 region2
       then no_end_region
       else add_end_region region1 ~region_stack_now
-    | Some (region, region_stack_now), None ->
+    | Some (((Regular _ | Try_with _) as region), region_stack_now), None ->
       add_end_region region ~region_stack_now
     | None, Some _ -> assert false
     (* see above *)

ocaml/testsuite/tests/typing-local/match_with_exception.ml

@@ -0,0 +1,20 @@
+(* TEST
+   * native *)
+
+let[@inline never] f x =
+  local_ (x, (0, 0))
+
+let[@inline never] g x =
+  local_ (x, 0)
+
+let[@inline never] h x =
+  match f x with
+  | exception Not_found -> 0
+  | p ->
+    (* The try-region must not have been closed, otherwise [p2] will
+       clobber [p] *)
+    let p2 = g x in
+    (fst (snd p)) + fst p2
+
+let () =
+  Printf.printf "%d\n" (h 0)

ocaml/testsuite/tests/typing-local/match_with_exception.reference

@@ -0,0 +1 @@
+0