-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental work to add cohttp support for opam-cross-windows #329
Draft
Jo-Blade
wants to merge
32
commits into
ocaml-cross:main
Choose a base branch
from
Jo-Blade:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to support cohttp (and especially cohttp-lwt-unix) in opam-cross-windows. My initial goal was to try to cross-compile a custom app that use cohttp-lwt-unix but it's a partial success only.
I managed to build and make cohttp work only with plain old HTTP and not HTTPS. For that I had to package a lot of stuff, feel free to take a look and give me some feedback.
I couldn't make ocaml-ssl detect windows ca-certificates. As an alternative I've considered ocaml-tls but couldn't cross compile it at all because of "make inconsistent assumptions over implementation".
The commits tree is very ugly due to a lot of trials and errors but if people are interested I can try to clean up a bit. For some packages (ptime and mtime) I had to modify the source code to convert the project to dune to be able to compile. You can find the patches in the "mnt" folder to have the same sources as me but it need to be properly integrated to opam when I will have more time.
I decided to create a draft pull request to help future people to learn from my try, even if it's not fully functional. If people are interested to help me I'm still interested in giving cohttp support otherwise I'm not sure I will continue cause of lack of time.
Thank you for your project