feat(config): allow publishing to SNS topic #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow AWS Config to publish change notifications to a provided SNS topic. We can not use `count` on `var.sns_topic_arn` to gate the construction of the IAM policy in this case. Terraform will complain it cannot determine the number of instances prior to apply. Instead we always declare a well formed policy, but only inline it if an SNS topic is provided.
bendrucker
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow AWS Config to publish change notifications to a provided SNS topic.
We can not use
countonvar.sns_topic_arnto gate the construction of the IAM policy in this case. Terraform will complain it cannot determine the number of instances prior to apply. Instead we always declare a well formed policy, but only inline it if an SNS topic is provided.