feat(spec-tests): introduce aws spec tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
reviewed
Sep 12, 2023
| @@ -76,7 +76,7 @@ resource "aws_iam_role_policy" "github_actions_s3_write_inline" { | |||
| } | |||
|
|
|||
| resource "github_actions_variable" "aws_release_role" { | |||
| repository = local.repository | |||
There was a problem hiding this comment.
Pretty sure the linter should prefer the previous formulation?
jta
approved these changes
Sep 12, 2023
|
Going to punt this for the DCE integrated version |
|
using this in the interm while DCE is still pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enabled the ability to run our AWS spec tests with only the cloudformation repository.
Putting the tests as workflow dispatch and every Monday until we have confidence in their stability / utility
Motivation
We should have tests
Testing
The spec tests run on the aws-test-kitchen repository successfully.
I've also ran these tests using a fork of the cloudformation-aws-collection repository
Example: https://github.com/observeinc/aws-test-kitchen/actions/runs/6151706105
Related: observeinc/terraform-aws-collection#85