Register missing Jaeger UI routes #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these routes, hitting refresh on the trace detail, system architecture or monitor page of Jaeger UI results in a 404. Navigating to these pages from the /search page does work without this PR, because Jaeger UI is a single-page application. But hitting refresh doesn't work without this PR. Signed-off-by: Andreas Gerstmayr <[email protected]>
saswatamcode
approved these changes
Nov 5, 2024
pavolloffay
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these routes, hitting refresh on the trace detail, system architecture or monitor page of Jaeger UI results in a 404.
Navigating to these pages from the /search page does work without this PR, because Jaeger UI is a single-page application. But hitting refresh doesn't work without this PR.
Ref. https://issues.redhat.com/browse/TRACING-4933
cc @rubenvp8510