Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid markerEnd option for link/arrow #2156

Open
aboveyunhai opened this issue Aug 29, 2024 · 1 comment
Open

invalid markerEnd option for link/arrow #2156

aboveyunhai opened this issue Aug 29, 2024 · 1 comment
Labels
bug Something isn’t working

Comments

@aboveyunhai
Copy link

aboveyunhai commented Aug 29, 2024

the current markerEnd: "arrow-reverse" has no effect for both link and arrow.
Not sure if it's the design choice or bug.

    Plot.link(data, {
      markerEnd: "arrow-reverse"
    })

if it's the choice then the following line should change to Exclude<Marker, "arrow-reverse"> for link | arrow

markerEnd?: Marker | "none" | boolean | null;

@aboveyunhai aboveyunhai added the bug Something isn’t working label Aug 29, 2024
@Fil
Copy link
Contributor

Fil commented Aug 30, 2024

This is working as expected, but the spec can be confusing: arrow-reverse is exactly like arrow but reversed on the starting position, so you can draw something like <-----> with a single marker.

I think that your proposed solution (excluding it from the markerEnd and markerMid defs) makes total sense; it's not that it's "not working", but in these two cases it's by definition doing nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

2 participants