try and close logsreceiver storage on receiver start errors #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
We were getting this error whenever we tried to start up with a bad config:
We noticed if the opentelemetry collector will invoke
Shutdown()
on the extensions or the receivers in the case that we cannot start thelogsreceiver
.This is most likely a bug with opentelemetry or how we are using it but given if we successfully setup the filestorage extension and it never invokes the
Close()
because the receiver fails to startup we get the aforementioned errorChecklist