Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try and close logsreceiver storage on receiver start errors #91

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented Sep 23, 2021

Proposed Change

We were getting this error whenever we tried to start up with a bad config:

panic: Collector failed to start: cannot setup pipelines: cannot start receivers: storage client: timeout

We noticed if the opentelemetry collector will invoke Shutdown() on the extensions or the receivers in the case that we cannot start the logsreceiver.

This is most likely a bug with opentelemetry or how we are using it but given if we successfully setup the filestorage extension and it never invokes the Close() because the receiver fails to startup we get the aforementioned error

Checklist
  • Changes are tested
  • Changes are documented

@schmikei schmikei changed the title try and close logsreceiver storage on storage get errors try and close logsreceiver storage on receiver start errors Sep 23, 2021
@schmikei schmikei marked this pull request as ready for review September 23, 2021 14:14
@schmikei schmikei requested a review from a team as a code owner September 23, 2021 14:14
@schmikei schmikei merged commit 6e9c73c into master Sep 24, 2021
@schmikei schmikei deleted the close-filestorage-extension-db-on-err branch September 24, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants