Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added azure aks #42

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Added azure aks #42

merged 2 commits into from
Aug 17, 2020

Conversation

jmwilliams89
Copy link
Contributor

No description provided.

camdencheek
camdencheek suggested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@camdencheek camdencheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it exists, this looks like this collects less than our vanilla k8s plugin. Specifically, it's missing the kubelet logs from journald. Is there a reason we don't just clone the k8s one?

@jmwilliams89 jmwilliams89 merged commit 389f5a9 into master Aug 17, 2020
@jmwilliams89 jmwilliams89 deleted the azure-aks branch August 17, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camdencheek camdencheek camdencheek approved these changes

@ericwholt ericwholt Awaiting requested review from ericwholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmwilliams89 @camdencheek