Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create openshift plugin #4

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Create openshift plugin #4

merged 2 commits into from
Jul 24, 2020

Conversation

camdencheek
Copy link
Contributor

No description provided.

@camdencheek camdencheek requested a review from ericwholt July 22, 2020 21:48
ericwholt
ericwholt reviewed Jul 22, 2020
View reviewed changes
plugins/openshift.yaml Outdated Show resolved Hide resolved
ericwholt
ericwholt reviewed Jul 22, 2020
View reviewed changes
plugins/openshift.yaml Outdated Show resolved Hide resolved
ericwholt
ericwholt reviewed Jul 22, 2020
View reviewed changes
plugins/openshift.yaml Outdated Show resolved Hide resolved
ericwholt
ericwholt reviewed Jul 22, 2020
View reviewed changes
plugins/openshift.yaml Outdated Show resolved Hide resolved
ericwholt
ericwholt suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@ericwholt ericwholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I added a couple of minor name change recommendations based on change requests by product team for other plugins.

@camdencheek camdencheek merged commit ace896e into master Jul 24, 2020
@camdencheek camdencheek deleted the openshift branch July 24, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwholt ericwholt ericwholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camdencheek @ericwholt