Added docker swarm #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
reviewed
Aug 12, 2020
| default: end | ||
|
|
||
| # Set Defaults | ||
| {{$message_log_path := default "/var/log/messages/*.log" .message_log_path}} |
There was a problem hiding this comment.
Maybe out of scope for this, but this path looks very wrong. /var/log/messages is not specific to docker swarm, and also is unlikely to exist on most systems. It seems like we should be using the journald operator for a source.
There was a problem hiding this comment.
I can't definitively say. The default path was pulled directly from the docker swarm log bundle. This might be one that we'll have to test against an actual environment first.
camdencheek
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.