Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem logging into my Gmail account #570

Open
sheng-liang opened this issue Nov 13, 2024 · 5 comments
Open

Problem logging into my Gmail account #570

sheng-liang opened this issue Nov 13, 2024 · 5 comments
Assignees
Labels
bug Something isn't working oauth

Comments

@sheng-liang
Copy link

I added some Gmail tools in my agent. The agent prompted me to authenticate. The agent fails to authenticate because I have Google Advanced Protection and apparently that does not work with GPTScript.

The problem is somehow the agent now thinks I'm logged in. Of course nothing works and the agent gives a timeout error

@thedadams
Copy link
Contributor

@njhale Can you take a look at this? Specifically, what happens when someone has "Google Advanced Protection" enabled, and why GPTScript thinks that the credential is valid.

@drpebcak
Copy link
Contributor

@njhale
Copy link
Member

njhale commented Nov 16, 2024

Just a few notes :

  1. The gateway token is never generated when oauth fails due to Advanced Protection being enabled
  2. Google doesn't redirect to Gateway when the failure occurs, so it's not clear that there's a way to know this happened (I'm going to test this more thoroughly on Monday to verify)
  3. The oauth2 tool polls indefinitely for the gateway token
  4. After 5 minutes, Otto8 cancels the run and a generic "timeout waiting for prompt response from user" message is bubbled up to the chat window
  5. This message isn't in the chat completion history, so the Agent has no knowledge that authentication timed out

When I tested this, the Agent didn't think I was logged in, but did try to call the tools again the next time I asked it to. This resulted in the auth flow triggering, and failing, again.

I'm going to try to get some design input on Monday, but my current plan is to make the timeout message less generic (since we know it's waiting on auth there) and inject it into the chat history if possible. That way the Agent will at least be minimally aware that an error took place and doesn't try to call the same tools again as if nothing happened.

@cjellick
Copy link
Contributor

One thought: If the timeout is specific to oauth, i feel like it should be 60 or 90 seconds rather than 5 minutes. Either the user is going to log in or not.

@njhale
Copy link
Member

njhale commented Dec 7, 2024

@sangee2004 OAuth prompts will now timeout after 90 seconds and provide a slightly more descriptive error message.

@cjellick cjellick added the bug Something isn't working label Dec 16, 2024
@njhale njhale added the oauth label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working oauth
Projects
None yet
Development

No branches or pull requests

5 participants