Generate the release diff with the OAK output #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with reaching the limit number of characters in the release notes
aleixpuigb
requested review from
gouttegd,
matentzn and
anitacaron
as code owners
gouttegd
requested changes
Oct 8, 2024
There was a problem hiding this comment.
No objection to the generation of another diff with OAK, but since we already have a src/ontology/diffs directory with a small Makefile to generate the existing diffs, I’d rather have the new rule added to that Makefile than directly to the uberon.Makefile. Especially since src/ontology/diffs/Makefile already contains a rule to download the latest released OBO version of the ontology, so there’s no need to duplicate that in uberon.Makefile.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Move the rule that produces the $(REPORTSDIR)/diff_release_oak.md diff file to the dedicated diffs/Makefile, and add it to the `all` target of that Makefile so that the new diff is automatically generated as part of the `release-diff` target.
gouttegd
approved these changes
Nov 9, 2024
|
Thank you @gouttegd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with reaching the limit number of characters in the release notes.