Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a coherent collected-metazoa ontology that includes all bridging axioms #2452

Closed
cmungall opened this issue May 4, 2022 · 4 comments
Labels
autoclosed-unfixed This issue has been closed automatically. Stale

Comments

@cmungall
Copy link
Member

cmungall commented May 4, 2022

I realize there may be smaller issues for this but I think we should tackle this as a whole

We want all metazoan ssAOs plus bridge axioms plus Uberon to have no unsatisfiable classes

This may need some compromise on the uberon side. We may need to relax some disjointness axioms (these can be retained as something that is used internally to check uberon, but are dropped from the main release). Having the ability to traverse up from terms to their uberon counterparts is a higher priority for users than ontological perfection.

The main challenge here will be space-vs-material distinctions. IMO this is irrelevant to biologists and I think it's OK if collected-metazoa drops CARO/BFO/COB so that we can conflate these. An alternative is to have a rule that no mod ssAO maps to spaces and we make a material counterpart for all.

Note: this task is impossible with the current official release of FMA as it is already incoherent but we should be able to use the bioportal release which has no disjointness axioms

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Nov 1, 2022
Copy link

github-actions bot commented Nov 2, 2023

This issue has been closed automatically because it has not been updated in 18 months. Please re-open if you still need this to be addressed.

@github-actions github-actions bot added the autoclosed-unfixed This issue has been closed automatically. label Nov 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
@anitacaron
Copy link
Collaborator

Maybe the PR #3102 is doing this?

@gouttegd
Copy link
Collaborator

gouttegd commented Nov 2, 2023

#3102 is the first step, to enforce taxon constraints over Uberon combined with all the ssAO bridges.

Then there is #3061, to overhaul how the bridges are generated, and after that there will be the overhaul of how collected- and composite-metazoan are generated.

The overhaul of the generating pipelines will not, in itself, fix any existing or future inconsistency in collected-metazoan, but it should help in fixing them, by making the whole thing easier to debug (notably, easier to rebuild after a change has been made).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclosed-unfixed This issue has been closed automatically. Stale
Projects
None yet
Development

No branches or pull requests

3 participants